Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged main into dev 1.29 branch #43682

Merged
merged 399 commits into from
Oct 28, 2023

Conversation

Princesso
Copy link
Contributor

This PR syncs the dev-1.29 branch with main to keep the dev-1.29 branch up to date.

cc: @katcosgrove @taniaduggal @drewhagen @harshitasao

tengqm and others added 30 commits October 10, 2023 14:20
…md_update

Add note after restore cmd to specify that data-dir will be (re)created
Update connect-applications-service.md
* Small mistake between sections of the document

The note for --kube-reserved-cgroup should match formatting for --system-reserved-cgroup.  This changes helps those match.

* Update reserve-compute-resources.md

---------

Co-authored-by: Qiming Teng <[email protected]>
Update connect-applications-service.md
…odaffinity

Fix example errors for CrossNamespacePodAffinity
…ansition-time

Add blog for PersistentVolume last phase transition time
* Remove redudant steps from instruction

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Tim Bannister <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Change line 313, and add missing line

* Fix missing command end on line 313

* Update connect-applications-service.md

---------

Co-authored-by: Michael <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Qiming Teng <[email protected]>
Clarify IBM Java and IBM Semeru Runtimes cgroupsV2 support
Include `initContainers` in list-all-running-container-images.md
[pl] Updated resources of README.md
Correct `collection` definition to a list of instances of a resource _type_
Added secret keyword to kubectl-command.html file
kubectl/jsonpath: add example of escaping termination character
Fixed the reference link for 'secret permissions with default mode'
[zh] sync list-all-running-container-images reserve-compute-resources managing-tls-in-a-cluster
The `krel` templates are the ones we use right now, while kubepkg got
removed in kubernetes/release#3313.

Signed-off-by: Sascha Grunert <[email protected]>
Package builds are now integrated into `krel obs`, means we do not have
to reference rapture any more. It also got removed in
kubernetes/release#3313.

Signed-off-by: Sascha Grunert <[email protected]>
Remove rapture reference for build admins
…es#43394)

* doc(etcd-maintenance): add reference to etcd-defrag CronJob

* doc: improve style according to style guide

* chore: fix file name
@Princesso
Copy link
Contributor Author

@caesarxuchao @bgrant0607 could you kindly review this PR and give your approval if everything looks good to you? Warm regards.

Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have 4 steering votes.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@pacoxu
Copy link
Member

pacoxu commented Oct 27, 2023

/approve

@katcosgrove
Copy link
Contributor

/check-cla

@sftim
Copy link
Contributor

sftim commented Oct 27, 2023

Hmm, I wonder what EasyCLA is playing at.

@katcosgrove
Copy link
Contributor

CI appears to be haunted

@MadhavJivrajani
Copy link
Contributor

/easycla

1 similar comment
@mrbobbytables
Copy link
Member

/easycla

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 27, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@Princesso
Copy link
Contributor Author

/check-cla

@Princesso
Copy link
Contributor Author

/retest

@MadhavJivrajani
Copy link
Contributor

/easycla

@mrbobbytables
Copy link
Member

/check-cla

@justaugustus
Copy link
Member

/approve (Steering)

nudges bots:
/check-cla

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, pacoxu, palnabarun, sftim, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member

While we're waiting... how about a:
/joke

@k8s-ci-robot
Copy link
Contributor

@justaugustus: What do you call a cow with two legs? Lean beef.

In response to this:

While we're waiting... how about a:
/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tengqm
Copy link
Contributor

tengqm commented Oct 28, 2023

Just out of curiosity ... since when the sync from main to a dev-1.xx branch needs an upcall to the steering committee, and even a quorum from the committee? The committee has no other important works to oversee or we are really trying to improve something? I can smell something bad from this based on what I witnessed somewhere else. A truly open community encourages all open contributions, open discussions and open collaborations. Redundant rules. policies or processes are invented and enforced only when there are no other choices. If there is a trend towards more bureaucracy rather than more productivity, please let us watch out and think twice. Does this PR really worth your precious time?

@katcosgrove
Copy link
Contributor

We do not usually need steering involvement to merge branch syncs. This PR requires it because it merges a site banner, and those require approval from steering. Please be kind.

@tengqm
Copy link
Contributor

tengqm commented Oct 28, 2023

We do not usually need steering involvement to merge branch syncs. This PR requires it because it merges a site banner, and those require approval from steering. Please be kind.

Sorry for being ignorance about this exception. I was hoping that we as a community foster more trusts to contributors and motivates them rather than spending time on rules, processes.
I was shocked by this thread because I never saw this before, during my 8 years involvement with the community. I was worrying.

@katcosgrove
Copy link
Contributor

/easycla

1 similar comment
@Priyankasaggu11929
Copy link
Member

/easycla

@Priyankasaggu11929
Copy link
Member

/check-cla

@Priyankasaggu11929
Copy link
Member

Per the discussion https://kubernetes.slack.com/archives/C1TU9EB9S/p1698411010005219?thread_ts=1698411010.005219&cid=C1TU9EB9S, going ahead and manually merging the PR.

@Priyankasaggu11929 Priyankasaggu11929 merged commit d05e393 into kubernetes:dev-1.29 Oct 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject committee/security-response Denotes an issue or PR intended to be handled by the product security committee. language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/uk Issues or PRs related to Ukrainian language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/security Categorizes an issue or PR as relevant to SIG Security. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.